[Dashboard]: Update in app wallet user api #5187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
MananTank,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 68ce724 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
ElasticBottle
changed the title
ElasticBottle
changed the title
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5187 +/- ##
==========================================
- Coverage 45.36% 45.36% -0.01%
==========================================
Files 1068 1068
Lines 55230 55233 +3
Branches 3971 3972 +1
==========================================
- Hits 25055 25054 -1
- Misses 29483 29487 +4
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more. |
joaquim-verges
approved these changes
Oct 28, 2024
| columnHelper.accessor("last_accessed_at", { | ||
| header: "Last login", | ||
| columnHelper.accessor("linkedAccounts", { | ||
| header: "Login Methods", |
ElasticBottle
added
the
merge-queue
Contributor
Author
Merge activity
|
## Problem solved
Updates the dashboard so that list of in app wallet will pull from thirdweb RDS.
NOTE: NEED TO UPDATE ENV VAR AFTER DEPLOYEMENT
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `thirdweb` wallet integration by exposing the `WalletUser` type, updating API endpoints, and improving the handling of embedded wallets in the dashboard. It also refines wallet user data display and pagination in the user interface.
### Detailed summary
- Exposed `WalletUser` type in `packages/thirdweb/src/exports/wallets.ts`.
- Updated API host URL in `apps/dashboard/src/constants/urls.ts`.
- Modified `embeddedWallets` function to include `page` parameter.
- Refactored `useEmbeddedWallets` to support pagination and improved error handling.
- Changed data structure in `useEmbeddedWallets` to return `users` and `totalPages`.
- Updated wallet user display logic in `apps/dashboard/src/components/embedded-wallets/Users/index.tsx`.
- Removed deprecated `withinDays` function from `apps/dashboard/src/utils/date-utils.ts`.
- Enhanced CSV download functionality to include all users and relevant details.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/update-in-app-wallet-user-api
branch
from
8066ab0 to
68ce724
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Updates the dashboard so that list of in app wallet will pull from thirdweb RDS.
NOTE: NEED TO UPDATE ENV VAR AFTER DEPLOYEMENT
PR-Codex overview
This PR focuses on enhancing the
thirdwebecosystem by exposing theWalletUsertype, updating API endpoints, and modifying wallet retrieval logic. It improves user identification in embedded wallets and refines data handling within the dashboard.Detailed summary
WalletUsertype inpackages/thirdweb/src/exports/wallets.ts.THIRDWEB_EWS_API_HOSTURL inapps/dashboard/src/constants/urls.ts.embeddedWalletsfunction to includepageparameter.useEmbeddedWalletsto fetch wallet data with pagination.apps/dashboard/src/components/embedded-wallets/Users/index.tsx.withinDaysfunction fromapps/dashboard/src/utils/date-utils.ts.